Skip to content

Fix RuboCop offenses#392

Closed
y-yagi wants to merge 1 commit into
roidrage:masterfrom
y-yagi:fix-rubocop
Closed

Fix RuboCop offenses#392
y-yagi wants to merge 1 commit into
roidrage:masterfrom
y-yagi:fix-rubocop

Conversation

@y-yagi

@y-yagi y-yagi commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

This PR fixes following offenses.

Offenses:

lograge.gemspec:31:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'actionpack',    '>= 4'
    ^^^^^^^^^^^^^^^^^^^^^^
lograge.gemspec:32:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'activesupport', '>= 4'
    ^^^^^^^^^^^^^^^^^^^^^^
lograge.gemspec:33:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'railties', '>= 4'
    ^^^^^^^^^^^^^^^^^^^^^^
lograge.gemspec:34:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'request_store', '~> 1.0'

This PR fixes following offenses.

```
Offenses:

lograge.gemspec:31:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'actionpack',    '>= 4'
    ^^^^^^^^^^^^^^^^^^^^^^
lograge.gemspec:32:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'activesupport', '>= 4'
    ^^^^^^^^^^^^^^^^^^^^^^
lograge.gemspec:33:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'railties', '>= 4'
    ^^^^^^^^^^^^^^^^^^^^^^
lograge.gemspec:34:5: C: [Corrected] Gemspec/AddRuntimeDependency: Use add_dependency instead of add_runtime_dependency.
  s.add_runtime_dependency 'request_store', '~> 1.0'
```
@johnnagro

Copy link
Copy Markdown
Collaborator

Thanks @y-yagi! This same fix (add_runtime_dependency → add_dependency) was
merged via #399, so it's already on master. The diff still shows here because
it's computed against the old merge base, but merging would be a no-op.
Closing as already resolved — appreciated!

@johnnagro johnnagro closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants