Repository navigation
chore: update Pushgate advisory review model - #162
Open
devs-rootstrap wants to merge 1 commit into
Open
devs-rootstrap wants to merge 1 commit into
devs-rootstrap wants to merge 1 commit into
Conversation
The advisory AI review in .pushgate.yml pointed at claude-sonnet-4-20250514, which the Claude CLI no longer serves. Pushgate then reported "model not found" and asked for an interactive confirmation on every push, which fails in any non-interactive push. Point it at the current Sonnet model instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
devs-rootstrap
requested review from
amaury901130,
asdolo and
fernandatoledo
and
a balanced review from Copilot
October 28, 2026 14:39
asdolo
approved these changes
Oct 28, 2026
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the advisory model update intended to prevent model-not-found failures during non-interactive pushes.
No open issues 🎉
What changed in this PR
Overall Review: ai:clean
Updates Pushgate’s advisory review model to address the reported “model not found” failure that interrupts non-interactive pushes.
Changes:
- Replaces
claude-sonnet-4-20250514withclaude-sonnet-5-5. - Leaves blocking checks and built-in policies unchanged.
No actionable issues identified. End-to-end pre-push validation remains untested, as noted in the PR.
| File | Description |
|---|---|
.pushgate.yml |
Updates the Claude model used for advisory AI reviews. |
Review effort: Balanced
asdolo
approved these changes
Oct 28, 2026
| # Provider-specific settings are kept below the provider name. | ||
| claude: | ||
| model: claude-sonnet-4-20250514 | ||
| model: claude-sonnet-5-5 |
Collaborator
There was a problem hiding this comment.
@devs-rootstrap is there a way to always use the latest version of sonnet here? So we don't need to keep bumping the sonnet version.
fernandatoledo
approved these changes
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira board reference:
What does this do?
Updates the model used by Pushgate's advisory AI review in
.pushgate.ymlfromclaude-sonnet-4-20250514toclaude-sonnet-5-5.Why did you do this?
The Claude CLI no longer serves
claude-sonnet-4-20250514. Pushgate reports "model not found", turns that into a warning, and asks for an interactive confirmation. Any push without a terminal attached (scripts, automation, some IDE integrations) is refused at that point even though every blocking check passed. Pointing the advisory review at a model the CLI still serves lets the review run again instead of failing on every push.Who/what does this impact?
Everyone who pushes to this repository with Pushgate installed. The blocking tools (type-check, eslint, lint, lint-translations, test) and the built-in policies are unchanged; only the advisory review's model changes.
Layer 2: Risk Classification
risk:low: a one-line config change to a local pre-push check.How did you test this?
Confirmed
claude --model claude-sonnet-5-5 -p ...answers, and that Pushgate passes the configured model straight through as--model.Not exercised through the pre-push hook itself: this branch was pushed from a fresh worktree without
node_modules, where husky's hooks are not installed. A reviewer with Pushgate set up can confirm by pushing any branch after merging.Tested on iOS
Tested on Android
Tested on a small device
Tested on a real device
Tested all flows related with this PR changes
Tested accessibility
Added tests
Notes:
The
diff_sizepolicy (max_changed_lines: 700,mode: warning) also needs an interactive confirmation when exceeded, so non-interactive pushes of larger branches are still refused. That is left as is here; worth a separate decision.🤖 Generated with Claude Code