Add testcase for services with buffer in the response only - #263
Add testcase for services with buffer in the response only#263mathias-luedtke wants to merge 1 commit into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
|
@adbidwai to take a look |
|
Hi, I can take a look at this. Thanks! |
fujitatomoya
left a comment
There was a problem hiding this comment.
I do not think we can take this without fixes, because this generates intentionally red test.
Signed-off-by: Mathias Lüdtke <mathias.luedtke@pal-robotics.com>
26b66a6 to
6222bb3
Compare
I can add the fix as well, but I need to know which option you do prefer (see #264) |
|
@fujitatomoya: Which fix would you prefer?
|
|
I'd say that the best option we got here is to hoist the include to the top-of-file system-header block, conditionally at the interface level with checking that interface requires the header. but i guess that perfectly acceptable fallback: always include <stdint.h> in the top block if that makes the complicatoin. I was thinking about the compile-time concern but stdint.h is one of the smallest headers in the standard library. what do you think? |
Description
This PR add a test case that shows that cpplint checks fail for generated code for services that have buffers in their response, but not in the request.
The same issue should happen for actions.
The tests will fail with:
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
This issue was introduced by #250