Repository navigation
reject ECDSA and DSA DNSSEC signatures of the wrong length - #1370
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dns.dnssec.validate()with an RRSIG whose signature has extra zero octets inserted before S:PublicECDSA.verifyslicessignature[:octets]/signature[octets:]andPublicDSA.verifyslicessignature[1:21]/signature[21:], then turns each half into an int, so the length is never checked and leading zeros in S (and the DSA T octet) don't matter. RFC 6605 section 4 fixes the ECDSA signature at 64 or 96 octets, and RFC 2536 section 3 fixes DSA at 41 octets with T matching the key. The result is that RRSIG signatures are malleable, and dnspython accepts signatures that conforming validators reject. EdDSA and RSA are already strict because cryptography checks the length for them.Both
verifymethods now raiseInvalidSignatureon a bad length (and on a mismatched T for DSA)._validate_rrsigalready catches that exception. I added tests totests/test_dnssecalgs.py, a whatsnew note, and RFC 2536 todoc/rfc.rst.