Repository navigation
Further improve NSEC base32 handling. - #1372
Merged
Merged
Conversation
If running under Python 3.15 or newer, we can use no-padding mode for encode and decode, rather than doing the padding ourselves. Also, move the comment describing the extra padding checks for <3.15 closer to the code doing the checks.
rthalley
pushed a commit
that referenced
this pull request
Oct 22, 2026
* Further improve NSEC base32 handling. If running under Python 3.15 or newer, we can use no-padding mode for encode and decode, rather than doing the padding ourselves. Also, move the comment describing the extra padding checks for <3.15 closer to the code doing the checks. * Invoke base64.b32hexdecode correctly. (cherry picked from commit 9978a71)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If running under Python 3.15 or newer, we can use no-padding mode for encode and decode, rather than doing the padding ourselves.
Also, move the comment describing the extra padding checks for <3.15 closer to the code doing the checks.