Repository navigation
Don't send basic.cancel-ok on a closing channel - #758
Merged
Merged
Conversation
A basic.cancel that arrives after channel.close was sent made the server close the connection with CHANNEL_ERROR (expected 'channel.open').
michaelklishin
approved these changes
Oct 28, 2026
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a server-sent
basic.cancelarrives after the client has sentchannel.close, thebasic.cancel-okreply (#754) hits a closed channel and the server closes the connection:This makes
basic_consume_spec.rbflaky on RabbitMQ 4.3.7+. Reproduced locally under load: 3 of 6 connections closed onmain, none with this change.