Skip to content

Resize partial evaluation histories safely #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 2 commits into from
Aug 30, 2026
+13 −2
Merged

Resize partial evaluation histories safely #1241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1661ac
Resize partial evaluation histories safely
OskarEichler Aug 29, 2026
46976dd
Test shrinking partial evaluation history
OskarEichler Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/irb/ext/eval_history.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ def initialize(size = 16) # :nodoc:
end

def size(size) # :nodoc:
if size != 0 && size < @size
@contents = @contents[@size - size .. @size]
if size.positive? && @contents.size > size
@contents = @contents.last(size)

@tompng tompng Aug 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Can you add a test for this?
Adding a test that does the below in test_eval_history.rb would be enough

out, err = execute_lines(
  "IRB.CurrentContext.eval_history = 2",
  "__",
  conf: { EVAL_HISTORY: 5 }
)

end
@size = size
end
Expand Down
11 changes: 11 additions & 0 deletions test/irb/test_eval_history.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,16 @@ def test_eval_history_respects_given_limit
# Because eval_history injects `__` into the history AND decide to ignore it, we only get <limit> - 1 results
assert_match("2 \"bar\"\n" + "3 \"baz\"\n" + "4 \"xyz\"\n", out)
end

def test_eval_history_can_shrink_before_reaching_configured_limit
out, err = execute_lines(
"IRB.CurrentContext.eval_history = 2",
"__",
conf: { EVAL_HISTORY: 5 }
)

assert_empty(err)
assert_match("=> 2\n" + "=> 1 2\n", out)
end
end
end