fix: measure does not measure when an exception occurs - #1247
Merged
Conversation
The reason it was failing it was because when an exception ocurred the code stop in result = block.() preventing the lines to display time to be executed. The begin, ensure forces the code to execute the other lines after the excception
tompng
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #533
Why
The failure occurred because an exception raised by
result = block.()stopped normal execution before the elapsed time could be calculated and displayed.Wrapping the evaluation in begin...ensure guarantees that the timing code runs even when the evaluated block raises an exception. The original exception is still propagated and handled normally afterward.
Proof