Skip to content

Fix self-repository uses: syntax (resolves code scanning findings) - #4

Merged
dduugg merged 1 commit into
mainfrom
fix-self-repository-syntax
Aug 31, 2026
Merged

Fix self-repository uses: syntax (resolves code scanning findings)#4
dduugg merged 1 commit into
mainfrom
fix-self-repository-syntax

Conversation

@dduugg

@dduugg dduugg commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Resolves the three open code scanning findings (zizmor/self-repository) at https://github.com/rubyatscale/rubyfmt-action/security/code-scanning.

  • All three flagged the same pattern: .github/workflows/ci.yml referencing this repo's own composite action via the older workspace-relative uses: ./ syntax. GitHub added a dedicated "self-repository" syntax (uses: $/...) for this, which zizmor now recommends since it isn't subject to runtime filesystem state.
  • Switched all three references (test-formatted, test-unformatted, test-macos jobs) from uses: ./ to uses: $/.
  • actionlint doesn't understand this syntax yet (rhysd/actionlint#711, still open) and misparses it as an incomplete repository reference. Added a scoped -ignore for that specific message so actionlint keeps checking everything else; left a comment pointing at the upstream issue so it's easy to remove later.

Test plan

  • zizmor --persona=regular . (v1.30.0, the version that introduced this audit) reports no findings.
  • actionlint passes locally with the added -ignore.
  • CI passes on this PR, confirming uses: $/ actually resolves this repo's composite action at runtime (this is a very new GitHub Actions feature, so this PR's own CI run is the real-world check).
  • Once merged, the code scanning alerts auto-resolve when main's next zizmor scan doesn't find them again.

Resolves the three zizmor/self-repository code scanning findings
(https://github.com/rubyatscale/rubyfmt-action/security/code-scanning/1,2,3)
by switching 'uses: ./' to 'uses: $/' for the three composite-action
references in this repo's own test jobs, per:
https://github.blog/changelog/2026-07-30-reference-same-repository-actions-with-self-repository-syntax/

actionlint (rhysd/actionlint#711) doesn't understand this syntax yet,
so its step now ignores that specific known-false-positive message.
@dduugg
dduugg merged commit 9219dba into main Aug 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant