Replace ludeeus/action-shellcheck with a direct, checksum-verified download - #5
Merged
Conversation
…wnload ludeeus/action-shellcheck hasn't been pushed to since June 2024. Rather than swap to a different third-party wrapper action, download the official koalaman/shellcheck release binary directly and verify its checksum, matching how this repo already handles actionlint and how action.sh handles rubyfmt itself.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ludeeus/action-shellcheckstep inci.yml'slintjob with a direct, checksum-verified download of the officialkoalaman/shellcheckv0.11.0Linux binary.ludeeus/action-shellcheckhasn't been pushed to since June 2024 and has 18 open issues. Rather than swap to a different third-party wrapper (e.g.reviewdog/action-shellcheck, which is healthier but still just a wrapper), this drops the wrapper layer entirely and downloads shellcheck the same way this repo already handlesactionlintin the step right below it, and the same wayaction.shdownloadsrubyfmtitself: pin an exact version, verify a checksum, run the binary directly.*.shfile in the repo (action.sh,support/sync-versions.sh).Test plan
zizmor --persona=regular .reports no findings.actionlintpasses.ubuntu-latest).