Skip to content

don't retry archive index download if it doesn't exist remotely. - #3270

Closed
syphar wants to merge 1 commit into
rust-lang:mainfrom
syphar:no-retry
Closed

syphar wants to merge 1 commit into
rust-lang:mainfrom
syphar:no-retry

Conversation

@syphar

@syphar syphar commented Mar 26, 2026 •

Copy link
Copy Markdown
Member
image

these metrics made me think about which errors are currently retried.

There is one case where we currently retry and shouldn't: when the index doesn't exist remotely. This can be just a normal Ok(None).

@syphar syphar self-assigned this Mar 26, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Mar 26, 2026
@syphar
syphar marked this pull request as ready for review March 26, 2026 09:22
@syphar
syphar requested a review from a team as a code owner March 26, 2026 09:22
@rustbot

rustbot commented May 3, 2026

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (possibly #3319) made this pull request unmergeable. Please resolve the merge conflicts.

@syphar syphar closed this Oct 9, 2026
@syphar
syphar deleted the no-retry branch October 9, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants