Repository navigation
storage/s3: reduce unnecessary retries, add cleanup for legacy storage - #3450
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
Member
Author
|
audit failure fixed in #3451 |
GuillaumeGomez
approved these changes
Aug 18, 2026
Member
|
Looks good to me, thanks! |
github-actions
Bot
added
S-waiting-on-deploy
syphar
changed the title
syphar
removed
the
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the
repackagecommand (that converted legacy single-file to archive-storage) I had regular errors in the cleanup phase. Since that was was only tried after everything else is finished, that wasn't an issue for the conversion itself.The error I was was from the AWS SDK, and about a mismatchin the XML schema when running
delete_prefix. Currently I don't know why that error happened.But: I checked an bucket-inventory (= file-list for the whole bucket), and there are plenty of remaining rustdoc or source files.
This command tries to clean these up. Likely I'll run into the same XML encoding errors, but no I'll print the file-list / error list to be able to debug these better.
Before actually running the delete, I'll
--dry-runthe command, and inspect the resulting file-list.