Skip to content

sentry/tracing: include request-span fields in sentry transaction - #3571

Merged
syphar merged 1 commit into
rust-lang:mainfrom
syphar:tracelayer
Oct 2, 2026
Merged

syphar merged 1 commit into
rust-lang:mainfrom
syphar:tracelayer

Conversation

@syphar

@syphar syphar commented Sep 30, 2026

Copy link
Copy Markdown
Member

We report server errors from two places:

  • TraceLayer::on_failure reports every 5xx status
  • in all the places where we return a 5xx error, we explicitly call error!() with details

But: Looking at this sentry error, coming from TraceLayer, I didn't see corresponding detailed error.

The only place where we might return 500 while not logging it is search_handler, where we return the crates.io search api status code directly to the client.

This change here will just add the span fields from TraceLayer (URL among others) to the sentry transaction, so we can see where that error actually comes from.

@syphar syphar self-assigned this Sep 30, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 30, 2026
@syphar
syphar marked this pull request as ready for review September 30, 2026 18:55
@syphar
syphar requested a review from a team as a code owner September 30, 2026 18:55
@syphar

syphar commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Sep 30, 2026
@syphar
syphar merged commit 26d8d6b into rust-lang:main Oct 2, 2026
12 checks passed
@syphar
syphar deleted the tracelayer branch October 2, 2026 09:57
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 2, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 5, 2026

This branch was successfully deployed

1 active deployment
github-pages — d4e4d6c5 Deployed Oct 2, 2026 by syphar via deploy #602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants