Repository navigation
sentry/tracing: include request-span fields in sentry transaction - #3571
Merged
Merged
Conversation
syphar
marked this pull request as ready for review
September 30, 2026 18:55
Member
Author
GuillaumeGomez
approved these changes
Oct 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We report server errors from two places:
TraceLayer::on_failurereports every 5xx statuserror!()with detailsBut: Looking at this sentry error, coming from
TraceLayer, I didn't see corresponding detailed error.The only place where we might return 500 while not logging it is
search_handler, where we return the crates.io search api status code directly to the client.This change here will just add the span fields from
TraceLayer(URL among others) to the sentry transaction, so we can see where that error actually comes from.