Repository navigation
watcher: log all watcher errors, make registry-fetch loop more resilient - #3579
Merged
Merged
Conversation
syphar
marked this pull request as ready for review
October 5, 2026 07:39
Member
Author
GuillaumeGomez
approved these changes
Oct 5, 2026
Member
|
Thanks! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we currently have an issue where the web server load leads to the db connection pool being exhausted, and some server errors being returned:

( I will fix that separately).
But: this lead to our watcher stopping to fetch new crates, without any error I saw.
This was a combination of two things:
watch_registryfunction as tokio task, but we never logged any errors.queue.is_lockedorIndex::from_configlead to just returning from that method, and stopping to check the registry.This starts to log the errors from 1), and makes our registry loop more resilient so we would retry in these cases.