Skip to content

watcher: log all watcher errors, make registry-fetch loop more resilient - #3579

Merged
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:watcher-error-handling
Oct 5, 2026
Merged

GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:watcher-error-handling

Conversation

@syphar

@syphar syphar commented Oct 5, 2026

Copy link
Copy Markdown
Member

we currently have an issue where the web server load leads to the db connection pool being exhausted, and some server errors being returned:
image

( I will fix that separately).

But: this lead to our watcher stopping to fetch new crates, without any error I saw.

This was a combination of two things:

  1. we just spawned the watch_registry function as tokio task, but we never logged any errors.
  2. errors in queue.is_locked or Index::from_config lead to just returning from that method, and stopping to check the registry.

This starts to log the errors from 1), and makes our registry loop more resilient so we would retry in these cases.

@syphar syphar self-assigned this Oct 5, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 5, 2026
@syphar
syphar marked this pull request as ready for review October 5, 2026 07:39
@syphar
syphar requested a review from a team as a code owner October 5, 2026 07:39
@syphar

syphar commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Oct 5, 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@GuillaumeGomez
GuillaumeGomez merged commit 6cfd15c into rust-lang:main Oct 5, 2026
12 checks passed
@GuillaumeGomez
GuillaumeGomez deleted the watcher-error-handling branch October 5, 2026 09:31
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 5, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 5, 2026

This branch was successfully deployed

1 active deployment
github-pages — 35de1ba7 Deployed Oct 5, 2026 by GuillaumeGomez via deploy #612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants