Repository navigation
drop "releases.readme" column - #3585
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
changed the title
Member
Author
Member
|
Weren't we talking about using this README field to store the generated and highlighted HTML? |
Member
Author
generally yes, but:
|
Member
|
Makes sense! |
GuillaumeGomez
approved these changes
Oct 7, 2026
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a long time we primarily fetch readmes from the source archive primarily.
We only used the database readme if there wasn't a cargo.toml, or if we didn't find the readme. But in these cases there wouldn't have been
releases.readmecontent anyways.So we can drop that column and save the database storage. Also, this will make the releases table faster to work with on the server, since rows will be smaller.
One exception: the old logic tried to read a
README.md, even when we didn't find aCargo.toml. I'm not sure if that's a case we really need to handle?