Repository navigation
support systemd socket activation - #3587
Merged
Merged
Conversation
syphar
marked this pull request as ready for review
October 7, 2026 15:45
Member
Author
This comment was marked as outdated.
This comment was marked as outdated.
GuillaumeGomez
approved these changes
Oct 7, 2026
Member
|
Thanks! |
Member
Author
|
ah damn.... I forgot to rebase / rename commits here on this PR, now it's on |
Member
Author
|
I rebased / force-pushed on main to fix the commit |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nginx currently returns 502s during deployments and webserver restarts. Across the last three restart windows, we observed 267–689 connection-refused errors per restart. These occur between the old webserver closing its listener during graceful shutdown and the new process accepting connections.
This PR adds systemd socket activation support to both docs_rs_web and the legacy daemon:
Without an inherited socket, the webserver binds its configured address as before. Socket activation should prevent these brief connection-refused outages, provided the backlog has capacity and requests stay within proxy timeouts.
I'll work on the server config once this change is deployed.
more info:
inherited listening sockets, and application support.
ListenStream,Accept=no,Backlog, and socket/service units.listenfd, includingLISTEN_PID,LISTEN_FDS, and FD 3.