Skip to content

build queue: right-align in-progress table - #3618

Merged
GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:queue-style
Oct 19, 2026
Merged

GuillaumeGomez merged 2 commits into
rust-lang:mainfrom
syphar:queue-style

Conversation

@syphar

@syphar syphar commented Oct 19, 2026

Copy link
Copy Markdown
Member

before:
image

after:
image

Happy to take recommendations for improvements.

@syphar syphar self-assigned this Oct 19, 2026
@github-actions github-actions Bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 19, 2026
@syphar

syphar commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

other odd looking example
image

@syphar
syphar marked this pull request as ready for review October 19, 2026 08:13
@syphar
syphar requested a review from a team as a code owner October 19, 2026 08:13
@syphar

syphar commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Oct 19, 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member

Tried it with (roughly):

th,td {
  text-align: left;
}

th:not(:first-child), td:not(:first-child) {
  width: fit-content;
  white-space: nowrap;
}

table {
    table-layout: auto;
}

Which gives:

image

What do you think?

@syphar

syphar commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

What do you think

code-wise this looks better :)

Generally: do you prefer the left-align for the durations over right-align?

Also, can you add a commit?

@rustbot

rustbot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

Copy link
Copy Markdown
Member

I tend to prefer left-aligned but I'm fine with right-aligned if it's what you prefer. And sure, can push a commit if the changes I propose look good to you.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Pushed my changes (so left-aligned). Tell me if you prefer right-aligned and I'll update my commit.

@syphar

syphar commented Oct 19, 2026

Copy link
Copy Markdown
Member Author

@GuillaumeGomez let's go with your idea first, can you approve?

@GuillaumeGomez
GuillaumeGomez merged commit be048a8 into rust-lang:main Oct 19, 2026
11 checks passed
@GuillaumeGomez
GuillaumeGomez deleted the queue-style branch October 19, 2026 11:55
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 19, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Oct 19, 2026

This branch was successfully deployed

1 active deployment
github-pages — d8126ad9 Deployed Oct 19, 2026 by GuillaumeGomez via deploy #749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants