Repository navigation
fix: override rust doc to handle long line comment - #3620
Its-Just-Nans wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
S-waiting-on-review
|
The solution here would be to make the top navbar |
I'm not sure to understand why the overflow is problematic. See on the video below. We can do the same (scroll) but without overflowing the page 
|
I've updated with a change like that I now understand the main issue: rust-lang/rust#109865 was created a explains that a horizontal scroll inside a container is a bug rust-lang/rust#109865 (comment) Then you fixed it with rust-lang/rust#109932 And now, in this MR, I am trying to fix the top header/navigation I've updated the MR |
|
Please add a GUI test too. |
| } | ||
|
|
||
| main { | ||
| margin-top: 32px; /* Offset of the fixed navigation bar */ |
There was a problem hiding this comment.
| margin-top: 32px; /* Offset of the fixed navigation bar */ | |
| margin-top: $top-navbar-height; |
| // topbar). | ||
| assert-window-property: {"innerWidth": |width|} | ||
| wait-for-document-property: {"documentElement"."clientWidth": |width|} | ||
| assert-css: ("body > .nav-container", {"position": "fixed"}) |
There was a problem hiding this comment.
That's not testing anything. ^^'
You need to reduce the window's width and scroll to the side to ensure that the topbar is not scrolled.
This branch has not been deployed
2 participants
Handle long comment in the source code viewer. When the comment/code is too long, the header is cut. (see video)
Following rust-lang/rust#164577