Invalid default-theme and preferred-dark-theme now cause an error - #3141
Conversation
There was a problem hiding this comment.
The string config for default-themes is now replaced by an enum, and deser of the config now fails on an unknown value.
The list of available themes is now injected into the view rather than hardcoded.
The documentation is updated, and a few tests are added to config.
Seems good to go!
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
|
Looks good to me, thanks! One last thing remain to be added: a ui test to check the book building fails. |
f815708 to
eab9ae4
Compare
|
Looks all good to me, thanks! |
This causes building to fail if
default-themeorpreferred-dark-themeis not one of the built-in themes.If
book.tomlhas an invaliddefault-theme:mdbook buildoutputs an error saying why:Fixes #3140