Repository navigation
Rollup of 4 pull requests - #164445
Closed
JonathanBrouwer wants to merge 9 commits into
Closed
Rollup of 4 pull requests#164445JonathanBrouwer wants to merge 9 commits into
JonathanBrouwer wants to merge 9 commits into
Conversation
…en unsupported. This eliminates the portability hazard (and inconsistent linting of `clippy::drop_non_drop`) of types having destructors on some platforms and not others. It is arguably a breaking change, but a breaking change that would also be required if any of these platforms later gains filesystem support. An alternative to this change would be to implement `Drop` on the `std::fs` types instead of the `std::sys` types. That would be more reliable, but would be more of a public API change since `T: Drop` bounds are unfortunately possible.
…Kobzol Add bootstrap step to build the TPDE plugin Adds TPDE steps to build the TPDE plugin on Linux targets and to optionally include it as part of the compiler sysroot for local development. Part of rust-lang/goals#802. This does not make any effort to be able to use TPDE in the compiler; all it does is stick a dylib in the place where it will eventually be needed. cc @ZuseZ4 r? Kobzol --------------- No LLMs were used to write this PR.
Add hightlight to acceptable characters in macro rules Add logic to highlight accepted characters in macro rules
diagnostic: skip wrong loops when explaining borrow errors Adresss rust-lang#164169 When dealing with loops, restrict the search to the specific loop where the conflict occurs. r? @estebank
Make `std::fs::{File, ReadDir, DirEntry}` always `needs_drop` even when unsupported.
This eliminates the portability hazard (and inconsistent linting of `clippy::drop_non_drop`) of types having destructors on some platforms and not others.
It is arguably a breaking change, but a breaking change that would also be required if any of these platforms later gains filesystem support.
An alternative to this change would be to implement `Drop` on the `std::fs` types instead of the `std::sys` types. That would be more reliable, but would be more of a public API change since `T: Drop` bounds are unfortunately possible.
rustbot
added
A-tidy
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
Rollup of 4 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
This comment has been minimized.
This comment has been minimized.
Contributor
|
⌛ Testing commit 474130e with merge 54faa20... Workflow: https://github.com/rust-lang/rust/actions/runs/38959237870 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
…uwer Rollup of 4 pull requests Successful merges: - #163731 (Add bootstrap step to build the TPDE plugin) - #164060 (Add hightlight to acceptable characters in macro rules) - #164424 (diagnostic: skip wrong loops when explaining borrow errors) - #162444 (Make `std::fs::{File, ReadDir, DirEntry}` always `needs_drop` even when unsupported.)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #164060, which is a member of this rollup, was unapproved. This rollup was thus unapproved. Auto build was cancelled due to unapproval. Cancelled workflows: |
Contributor
|
💔 Test for 334e67b failed: CI. Failed jobs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
std::fs::{File, ReadDir, DirEntry}alwaysneeds_dropeven when unsupported. #162444 (Makestd::fs::{File, ReadDir, DirEntry}alwaysneeds_dropeven when unsupported.)r? @ghost
Create a similar rollup