Repository navigation
rustdoc: Move the "copy path" button out of the HTML and generate it with JS - #164447
Open
GuillaumeGomez wants to merge 1 commit into
Open
GuillaumeGomez wants to merge 1 commit into
GuillaumeGomez wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
A-rustdoc-js
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
move-copy-path-out-of-js
branch
from
October 16, 2026 21:33
50601fc to
36fefb8
Compare
notriddle
requested changes
Oct 17, 2026
Contributor
There was a problem hiding this comment.
As it is now, on a slow connection you can get layout shift. It's not a lot, but it's noticeable, and we've always done a pretty good job to avoid it before.
Screen.Recording.2026-10-16.at.19.59.06.mov
To avoid this, I think you could inserting the copy path button in [RustdocToolbarElement::connectedCallback][], or a new custom element, or a MutationObserver registered in storage.js.
| // We check that the clipboard value is the expected one. | ||
| assert-clipboard: "test_docs" | ||
|
|
||
| // Now check the presence of the "copy code" button. Above we already checked for items, crate |
Contributor
There was a problem hiding this comment.
“Copy code”? Don’t you mean “copy path”?
rustbot
added
S-waiting-on-author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few things in the HTML that are only used when JS is enabled. So instead of generating them for each page, better generate them with JS. I'll send a few PRs after this one for each element.
r? @notriddle