Repository navigation
Conversation
rustbot
added
A-LLVM
rust-cloud-vms
Bot
force-pushed
the
offload-cleanup-1
branch
from
October 17, 2026 06:11
2c08c13 to
80d95cc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #164057
Since #162309 removed the
clang-linker-wrapperstep, nothing readsdevice.binanymore, and its triple/arch are already in the bitcode.
So, as the first step, I removed steps generating and extracting device.bin, instead we're going to use the device bitcode.
As a next step, the host pass could take the linked device output(
.ptxfor NVPTX,.elffor AMDGPU) instead, whichwould remove the second codegen. I'd like to do that in a separate PR.
I'll update rustc-dev-guide in a follow-up PR in their repo.
I verified that this change works by running offload sample code on UofT gpunode.
r? ZuseZ4