Skip to content

Arbitrary self types v2: dev guide updates. - #2168

Open
adetaylor wants to merge 1 commit into
rust-lang:mainfrom
adetaylor:arbitrary-self-types-v2
Open

Arbitrary self types v2: dev guide updates.#2168
adetaylor wants to merge 1 commit into
rust-lang:mainfrom
adetaylor:arbitrary-self-types-v2

Conversation

@adetaylor

Copy link
Copy Markdown

No description provided.

@jieyouxu jieyouxu added S-blocked Status: this PR is blocked waiting for something F-arbitrary_self_types Feature: arbitrary_self_types T-compiler Relevant to the compiler team T-types Relevant to the types team labels Dec 20, 2024
@Kobzol

Kobzol commented Jan 5, 2025

Copy link
Copy Markdown
Member

Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new master):

git fetch origin --all
git checkout <pr-branch>
git rebase --onto origin/master origin/master-old
git push --force-with-lease

More context can be found here.

@adetaylor
adetaylor force-pushed the arbitrary-self-types-v2 branch from f21f094 to 2f266b5 Compare January 28, 2025 08:58
@adetaylor
adetaylor marked this pull request as ready for review January 28, 2025 08:59
@rustbot

rustbot commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (possibly #2795) made this pull request unmergeable. Please resolve the merge conflicts.

@jyn514 jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi! I know it's been a very long time. Are you still interested in getting this PR merged? I'm happy to commit to reviewing it (and even rebasing it if you like), I just want to be sure the docs are up to date since they're ~2 years old.

View changes since this review

@jyn514

jyn514 commented Aug 17, 2026

Copy link
Copy Markdown
Member

Does anyone know who could review this? I see @programmerjake has commented on the tracking issue recently, could you review it for accuracy? Or perhaps write your own docs if this is too outdated?

@jyn514 jyn514 added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-blocked Status: this PR is blocked waiting for something labels Aug 17, 2026
@programmerjake

Copy link
Copy Markdown
Member

I'm not familiar with the compiler-level implementation of this, my knowledge just comes from iirc the reference's description and the library and from the discussion on how I and some others think we should decouple Deref and Receiver, which lead to rust-lang/rust#146095 by @dingxiangfei2009 which will change how this is done enough that this PR would need to be mostly rewritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-arbitrary_self_types Feature: arbitrary_self_types S-waiting-on-author Status: this PR is waiting for additional action by the OP T-compiler Relevant to the compiler team T-types Relevant to the types team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants