Repository navigation
Rework GAS accesses to fixed register blocks - #373
Open
IsaacWoods wants to merge 3 commits into
Open
IsaacWoods wants to merge 3 commits into
IsaacWoods wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
read_u16andwrite_u16methods onGenericAddress, and fixes accesses to thePM1register blocks by splitting them into their componentSTSandENregisters.This does throw in a few unrelated changes that I have had locally on my
mainbranch from poorgitting I'm afraid - I have not rebased these off as I don't think they reduce reviewability and I'd like them to go in at some point.cc @martin-hughes - we've discussed complexities around handling these accesses. I'd be interested in your thoughts on this solution.