Add openssl pkg to alpine to provide libcrypto#2116
Conversation
24f5730 to
b7cde8b
Compare
| __git_clone_and_checkout || return 1 | ||
|
|
||
| apk -U add python3 python3-dev py3-pip py3-setuptools g++ linux-headers zeromq-dev openrc || return 1 | ||
| apk -U add python3 python3-dev py3-pip py3-setuptools g++ linux-headers zeromq-dev openrc openssl-dev || return 1 |
There was a problem hiding this comment.
Blocker: The PR title and description state that this is adding the openssl package to provide libcrypto for a runtime dependency. However, the code adds openssl-dev instead of openssl.
If the goal is strictly to provide the libcrypto shared library for runtime execution, we should just install openssl (or libcrypto3/libcrypto1.1 explicitly depending on the Alpine version) to keep the bootstrap footprint minimal. Adding -dev headers introduces unnecessary build dependencies unless we are explicitly compiling a Python wheel against OpenSSL headers during this git dependency installation phase.
If we do need the development headers for a compilation step here, the PR title should be updated to reflect that, but otherwise, this should be switched to the runtime package.
Suggested Change:
apk -U add python3 python3-dev py3-pip py3-setuptools g++ linux-headers zeromq-dev openrc openssl || return 1
What does this PR do?
Adds the
openssl-devpackage to alpine installs, which salt needs to run.What issues does this PR fix or reference?
After an install on alpine linux, salt throws errors due to missing crypto libs:
error output