Skip to content

test: cover the models and histograms - #1831

Open
ariostas wants to merge 2 commits into
scikit-hep:mainfrom
ariostas:test/models-coverage
Open

ariostas wants to merge 2 commits into
scikit-hep:mainfrom
ariostas:test/models-coverage

Conversation

@ariostas

@ariostas ariostas commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Part of the split of #1814 (the list is in #1834). These are the new tests of #1814 for the models (deserialization, guards, the Model machinery, old class versions, small classes, streamers) and the histogram models and behaviors, apart from the regression tests of its fixes, which are in the fix PRs. All of them pass on main.

It only adds test files.

@github-actions github-actions Bot added the type/test PR title type: test (set automatically) label Nov 6, 2026
@ariostas
ariostas marked this pull request as ready for review November 6, 2026 14:47
@codecov

codecov Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.68%. Comparing base (e12d2a4) to head (bb51a68).

Additional details and impacted files

see 48 files with indirect coverage changes

@ariostas
ariostas force-pushed the test/models-coverage branch from 2775833 to 04b4a47 Compare November 6, 2026 15:10
@ariostas
ariostas force-pushed the test/existing-tests branch from c192219 to 5253a21 Compare November 6, 2026 15:10
@ariostas
ariostas force-pushed the test/models-coverage branch from 04b4a47 to bb51a68 Compare November 6, 2026 16:25
New tests from scikit-hep#1814, apart from the regression tests of its fixes.

Assisted-by: Claude Code:claude-opus-5-5
The edges of the variable-width axis spanned exactly fXmin to fXmax, so the
test couldn't tell the mean of the widths from (fXmax - fXmin) / fNbins. The
files that Rewritable opens are now closed after each test. The test of a
version 3 TStreamerElement leaves for scikit-hep#1824, which reads its range.

Assisted-by: Claude Code:claude-opus-5-5
@ariostas
ariostas changed the base branch from test/existing-tests to main November 12, 2026 16:02
@ariostas
ariostas force-pushed the test/models-coverage branch from bb51a68 to 4a95ee6 Compare November 12, 2026 16:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/test PR title type: test (set automatically)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant