Skip to content

fix: use the module paths of graphed names that left its top level - #1843

Open
ariostas wants to merge 1 commit into
scikit-hep:mainfrom
ariostas:fix/graphed-deprecations
Open

ariostas wants to merge 1 commit into
scikit-hep:mainfrom
ariostas:fix/graphed-deprecations

Conversation

@ariostas

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

graphed 0.0.11 moved some names out of its top level, and accessing them there now gives a DeprecationWarning, which the test suite turns into an error. That makes the graphed tests fail on every PR (for example #1841).

Uproot used three of them: BufferNeed, refuse_chunk_partials and resolve_backend. This uses graphed.projection.BufferNeed, graphed.execute.refuse_chunk_partials and graphed.aggregate.resolve_backend instead, which have existed since graphed 0.0.9 (the minimum Uproot supports), and imports those submodules in uproot.extras.graphed. No other moved name is used.

graphed 0.0.11 deprecated BufferNeed, refuse_chunk_partials and
resolve_backend at the top level, and the warnings make the graphed
tests fail. They have been in graphed.projection, graphed.execute and
graphed.aggregate since 0.0.9, the minimum version uproot supports.

Assisted-by: Claude Code:claude-opus-5-5
@github-actions github-actions Bot added the type/fix PR title type: fix (set automatically) label Nov 12, 2026
@ariostas
ariostas marked this pull request as ready for review November 12, 2026 16:24
@ariostas

Copy link
Copy Markdown
Member Author

@lgray does this look fine to you?

@ianna ianna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas -- Thanks! LGTM

@ariostas
ariostas enabled auto-merge (squash) November 12, 2026 17:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix PR title type: fix (set automatically)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants