fix: fix videoAlpha being in percentage in older files, so loosen val… - #142
Merged
KFilosofov merged 1 commit intoAug 12, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
This PR updates the Scratch 2.0 (SB2) JSON Schema definitions to accept older projects where the videoAlpha field is stored as a percentage rather than a 0–1 alpha value, preventing valid legacy SB2 files from failing validation.
Changes:
- Loosen SB2 schema constraint for
videoAlphaby increasing its allowed maximum from1to100.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
174
to
178
| "videoAlpha": { | ||
| "type": "number", | ||
| "minimum": 0, | ||
| "maximum": 1 | ||
| "maximum": 100 | ||
| }, |
georgyangelov
approved these changes
Aug 10, 2026
cwillisf
approved these changes
Aug 11, 2026
cwillisf
left a comment
cwillisf
left a comment
Contributor
There was a problem hiding this comment.
Oof... this seems like the right change here, but I'm uncomfortable with the idea of this field being exactly 1 in an older project 😅
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to loosen the validation schema for the sb2 file types, the videoAlpha field is in percentage in older files so they fail being validated.