Test React on Rails 17.0.0.rc.7#775
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
ReviewThis PR is a mechanical dependency bump ( However, the PR's own RC Test Report documents a confirmed regression and marks this lane BLOCKED — I'd treat that as a hard blocker, not just informational:
Given that, this shouldn't be merged as-is per the report's own conclusion — either the upstream rc.7 regression needs a fix/explanation, or this needs to be explicitly waived by whoever owns the react_on_rails 17.0.0 release gate. No other issues found in the diff itself. |
RC Test Report
Status: BLOCKED
This hard-gate demo-fleet PR tests the React on Rails 17.0.0.rc.7 package set in
shakacode/react-webpack-rails-tutorial.Target Versions
react_on_railsgem:17.0.0.rc.7(transitive throughreact_on_rails_pro)react-on-railsnpm package:17.0.0-rc.7(transitive throughreact-on-rails-pro)react_on_rails_progem:17.0.0.rc.7react-on-rails-pronpm package:17.0.0-rc.7react-on-rails-pro-node-renderernpm package:17.0.0-rc.7react-on-rails-rscnpm package:19.2.1-rc.0(required by the rc.7 node renderer during RC soak)shakapackergem/npm package: unchanged at10.2.0Baseline
production-2026-06-04-034633-26929107280, deployment4928065047, commitc5f3b16f7e45dbf53c951eb6c81252e5102800d4, deployment statussuccess.react_on_rails/react_on_rails_pro16.7.0.rc.3, Pro npm packages16.7.0-rc.3,react-on-rails-rsc19.0.4, shakapacker10.1.0.origin/masterat196504a, withreact_on_rails/react_on_rails_pro17.0.0.rc.6, Pro npm packages17.0.0-rc.6,react-on-rails-rsc19.2.0, shakapacker10.2.0.Changes
react_on_railsgem andreact-on-railsnpm package at rc.7.react-on-rails-rscfrom19.2.0to19.2.1-rc.0because the rc.7 node renderer refuses to start with19.2.0.Gemfile.lock,yarn.lock, and the README version-target block.Feature Accounting
.ruby-version/Gemfile Ruby3.4.6.config.server_render_method: not present.generated_assets_dirs,skip_display_none,defer_generated_component_packs: not present. Existing singularconfig.generated_assets_dirremains test-only app config.hydrate_onscheduling/fixes: not used in this app.createRailsAction/ TanStack: not applicable; app has classic Rails/Jbuilder JSON and Redux, no TanStack orcreateRailsActionsurface.bin/devclean and generator-created app files: not applicable to this dependency bump; this repo is not exercising install/generator output in this lane.getStore(false): applicable throughNavigationBarApp; comment route/system specs passed with the rc.7 renderer running.Validation
bin/conductor-exec bundle install: PASS. Resolvedreact_on_railsandreact_on_rails_proto17.0.0.rc.7; Bundler also updated transitiveasync/io-event.bin/conductor-exec yarn install: PASS after correcting a local command typo (--frozen-lockfile=falseis not valid Yarn classic syntax). Yarn warnings are existing peer warnings for React 19-era deps.bin/conductor-exec yarn res:build && bin/conductor-exec bin/rails react_on_rails:locale && bin/conductor-exec bin/rails react_on_rails:generate_packs && bin/conductor-exec bin/shakapacker: PASS.bin/conductor-exec bin/shakapacker: PASS after generated ReScript/locale/pack files existed. Cold direct run failed first because this app requires generatedclient/app/generated/server-bundle-generated.js; that matches the app initializer comments.RENDERER_URL=http://localhost:3801 bin/conductor-exec bundle exec rspec: FAIL,48 examples, 1 failure.spec/system/server_components_demo_spec.rb:35ErrorBoundaryfallback textServer component fetch failedafter clickingSimulate Error.LiveActivitycontent (Refresh count: 1), while the rc.7 node renderer loggedSimulated server-side render failure (demo)for theLiveActivityRSC payload request.origin/master(17.0.0.rc.6+react-on-rails-rsc 19.2.0) passes the same isolated example with its own renderer on port 3802:RENDERER_URL=http://localhost:3802 bin/conductor-exec bundle exec rspec spec/system/server_components_demo_spec.rb:35: PASS,1 example, 0 failures./:http://127.0.0.1:3027withRENDERER_URL=http://localhost:3801.curl http://127.0.0.1:3027/: HTTP 200./; titleReact Webpack Rails Tutorial, H1A cleaner way to explore Rails, React, and server rendering together.,#RouterApp-react-component-0present,#git-commit-shapresent.Known Failures / Issues
RSCRoute+ErrorBoundaryno longer shows the fallback for the simulated server-component error in this demo. rc.6 baseline passes; rc.7 fails. No new React on Rails issue created from this lane per release-gate instructions.Release Impact
Do not count this hard-gate lane as green for React on Rails 17.0.0 final until the rc.7 RSC error-boundary regression is fixed, explained, or explicitly waived.