Skip to content

Test React on Rails 17.0.0.rc.7#775

Draft
justin808 wants to merge 1 commit into
masterfrom
chore/demo-fleet-17-rc7
Draft

Test React on Rails 17.0.0.rc.7#775
justin808 wants to merge 1 commit into
masterfrom
chore/demo-fleet-17-rc7

Conversation

@justin808

Copy link
Copy Markdown
Member

RC Test Report

Status: BLOCKED

This hard-gate demo-fleet PR tests the React on Rails 17.0.0.rc.7 package set in shakacode/react-webpack-rails-tutorial.

Target Versions

  • react_on_rails gem: 17.0.0.rc.7 (transitive through react_on_rails_pro)
  • react-on-rails npm package: 17.0.0-rc.7 (transitive through react-on-rails-pro)
  • react_on_rails_pro gem: 17.0.0.rc.7
  • react-on-rails-pro npm package: 17.0.0-rc.7
  • react-on-rails-pro-node-renderer npm package: 17.0.0-rc.7
  • react-on-rails-rsc npm package: 19.2.1-rc.0 (required by the rc.7 node renderer during RC soak)
  • shakapacker gem/npm package: unchanged at 10.2.0

Baseline

  • Last deployed baseline discovered from GitHub production release/deployment: production-2026-06-04-034633-26929107280, deployment 4928065047, commit c5f3b16f7e45dbf53c951eb6c81252e5102800d4, deployment status success.
  • Last deployed locks: react_on_rails/react_on_rails_pro 16.7.0.rc.3, Pro npm packages 16.7.0-rc.3, react-on-rails-rsc 19.0.4, shakapacker 10.1.0.
  • Current default branch baseline under test: origin/master at 196504a, with react_on_rails/react_on_rails_pro 17.0.0.rc.6, Pro npm packages 17.0.0-rc.6, react-on-rails-rsc 19.2.0, shakapacker 10.2.0.

Changes

  • Bumped the direct Pro Ruby/npm pins from rc.6 to rc.7 so the app resolves the underlying OSS react_on_rails gem and react-on-rails npm package at rc.7.
  • Bumped react-on-rails-rsc from 19.2.0 to 19.2.1-rc.0 because the rc.7 node renderer refuses to start with 19.2.0.
  • Updated Gemfile.lock, yarn.lock, and the README version-target block.
  • Did not bump shakapacker.

Feature Accounting

  • Ruby 3.3+ requirement: applicable and already satisfied by .ruby-version/Gemfile Ruby 3.4.6.
  • Removed config.server_render_method: not present.
  • Deprecated generated_assets_dirs, skip_display_none, defer_generated_component_packs: not present. Existing singular config.generated_assets_dir remains test-only app config.
  • hydrate_on scheduling/fixes: not used in this app.
  • RSC/SSR/Node Renderer: applicable. Build and RSC request specs pass, but one RSC client error-boundary system spec regresses under rc.7.
  • Typed response generation / createRailsAction / TanStack: not applicable; app has classic Rails/Jbuilder JSON and Redux, no TanStack or createRailsAction surface.
  • bin/dev clean and generator-created app files: not applicable to this dependency bump; this repo is not exercising install/generator output in this lane.
  • getStore(false): applicable through NavigationBarApp; comment route/system specs passed with the rc.7 renderer running.

Validation

  • bin/conductor-exec bundle install: PASS. Resolved react_on_rails and react_on_rails_pro to 17.0.0.rc.7; Bundler also updated transitive async/io-event.
  • bin/conductor-exec yarn install: PASS after correcting a local command typo (--frozen-lockfile=false is not valid Yarn classic syntax). Yarn warnings are existing peer warnings for React 19-era deps.
  • bin/conductor-exec yarn res:build && bin/conductor-exec bin/rails react_on_rails:locale && bin/conductor-exec bin/rails react_on_rails:generate_packs && bin/conductor-exec bin/shakapacker: PASS.
  • bin/conductor-exec bin/shakapacker: PASS after generated ReScript/locale/pack files existed. Cold direct run failed first because this app requires generated client/app/generated/server-bundle-generated.js; that matches the app initializer comments.
  • RENDERER_URL=http://localhost:3801 bin/conductor-exec bundle exec rspec: FAIL, 48 examples, 1 failure.
    • Failure: spec/system/server_components_demo_spec.rb:35
    • Expected the RSC ErrorBoundary fallback text Server component fetch failed after clicking Simulate Error.
    • Actual: browser remained on the previous LiveActivity content (Refresh count: 1), while the rc.7 node renderer logged Simulated server-side render failure (demo) for the LiveActivity RSC payload request.
  • Baseline comparison: current origin/master (17.0.0.rc.6 + react-on-rails-rsc 19.2.0) passes the same isolated example with its own renderer on port 3802:
    • RENDERER_URL=http://localhost:3802 bin/conductor-exec bundle exec rspec spec/system/server_components_demo_spec.rb:35: PASS, 1 example, 0 failures.
  • Smoke /:
    • Rails app started at http://127.0.0.1:3027 with RENDERER_URL=http://localhost:3801.
    • curl http://127.0.0.1:3027/: HTTP 200.
    • In-app browser loaded /; title React Webpack Rails Tutorial, H1 A cleaner way to explore Rails, React, and server rendering together., #RouterApp-react-component-0 present, #git-commit-sha present.
    • Console observed existing warnings plus React Intl missing locale data error; prior related tutorial issue: Fix i18n issue (Missing locale) #559.

Known Failures / Issues

Release Impact

Do not count this hard-gate lane as green for React on Rails 17.0.0 final until the rc.7 RSC error-boundary regression is fixed, explained, or explicitly waived.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c466df42-4ee9-4a96-9213-94a2e827bfe7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/demo-fleet-17-rc7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

🚀 Quick Review App Commands

Welcome! Here are the commands you can use in this PR:
They require the repository to have cpflow review apps configured, including the CPLN_TOKEN_STAGING secret.

+review-app-deploy

Deploy your PR branch for testing.

+review-app-delete

Remove the review app when done.

+review-app-help

Show detailed instructions, environment setup, and configuration options.

Comment +review-app-help for full setup details.

@claude

claude Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review

This PR is a mechanical dependency bump (react_on_rails_pro/react_on_rails gem+npm, and react-on-rails-rsc, from rc.6 → rc.7), and the version references are internally consistent — Gemfile, Gemfile.lock, package.json, yarn.lock, and the README.md version-targets table all agree on 17.0.0.rc.7 / 19.2.1-rc.0, with no stale rc.6 references left behind.

However, the PR's own RC Test Report documents a confirmed regression and marks this lane BLOCKED — I'd treat that as a hard blocker, not just informational:

  • spec/system/server_components_demo_spec.rb:35 ("shows the ErrorBoundary fallback when Simulate Error is clicked, then recovers on Retry") fails under rc.7 but passes under the current master baseline (rc.6 + react-on-rails-rsc 19.2.0). The RSC ErrorBoundary no longer surfaces the Server component fetch failed fallback when the node renderer simulates a server-side render failure — the UI just keeps showing stale LiveActivity content instead.
  • This is a real, reproducible functional regression in error-handling behavior (not flaky/environmental), since the report explicitly re-ran the same isolated example against both renderer versions on different ports and got different results.

Given that, this shouldn't be merged as-is per the report's own conclusion — either the upstream rc.7 regression needs a fix/explanation, or this needs to be explicitly waived by whoever owns the react_on_rails 17.0.0 release gate. No other issues found in the diff itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant