Skip to content

refactor: use NotEqualsFilter for single-field negations - #255

Closed
Vin Le (vienthuong) wants to merge 1 commit into
trunkfrom
refactor/use-not-equals-filter
Closed

Vin Le (vienthuong) wants to merge 1 commit into
trunkfrom
refactor/use-not-equals-filter

Conversation

@vienthuong

@vienthuong Vin Le (vienthuong) commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

1. Why is this change necessary?

Same simplification as shopware/shopware#22866: NotFilter(AND|OR, [EqualsFilter(...)]) with a single filter is what NotEqualsFilter already is.

2. What does this change do, exactly?

Replaces 23 hand-built single-field negations with NotEqualsFilter. Negations of null on association paths (a.b) are left alone.

3. Describe each step to reproduce the issue or behaviour.

Not applicable. Existing tests cover the changed code; they were not run locally.

5. Checklist

  • I have created the PR in draft status and only open it when it's ready for review
  • I have updated developer-facing release notes if this change affects external developers

@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.46%. Comparing base (2deb3cb) to head (0836c34).

Files with missing lines Patch % Lines
...vider/Data/ProductCanonicalAssociationProvider.php 0.00% 3 Missing ⚠️
...rovider/Data/ProductCmsPageAssociationProvider.php 0.00% 3 Missing ⚠️
...ider/Provider/Data/CategoryAssociationProvider.php 0.00% 2 Missing ⚠️
...ovider/Data/CategoryCmsPageAssociationProvider.php 0.00% 2 Missing ⚠️
.../Data/CategoryProductStreamAssociationProvider.php 0.00% 2 Missing ⚠️
...r/Provider/Data/MediaFolderInheritanceProvider.php 0.00% 2 Missing ⚠️
...er/Data/ProductStreamFilterInheritanceProvider.php 0.00% 2 Missing ⚠️
...ata/SalesChannelHomeCmsPageAssociationProvider.php 0.00% 2 Missing ⚠️
...ider/Provider/Data/DocumentInheritanceProvider.php 50.00% 1 Missing ⚠️
src/DataProvider/Provider/Data/ProductProvider.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #255      +/-   ##
============================================
+ Coverage     65.37%   65.46%   +0.09%     
  Complexity     4790     4790              
============================================
  Files           654      654              
  Lines         21760    21722      -38     
============================================
- Hits          14225    14221       -4     
+ Misses         7535     7501      -34     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant