Skip to content

Lone % signs are removed from the template. #2

Open

Description

@stephband

Hi. I've been playing around with Djangode and ran into a problem. The template system is removing lone % characters. After a bit of searching I found that on line 38 of template.js the regexp:

/(?:{{|}}|{%|%})|[{}|]|[^{}%|]+/g

is removing, or ignoring, them. Now, I'm not sure if it's deliberately like that or not (although I don't remember % characters being an issue when working with Django templates). I think the fix is:

/(?:{{|}}|{%|%})|[{}%|]|[^{}%|]+/g

...but I'm not sure what I might be breaking by doing this, because I'll admit I don't fully understand all that is happening in the tokenizer/parser. I've run a few rudimentary tests and this change hasn't caused any problems.

Cheers!
Stephen.

Activity

  1. ahem commented on Apr 5, 2010

    @ahem
    Contributor

    All the tests still parse with the changed regex, so it looks like it works. I added the change to in change in my branch together with a test against the '%' bug.

    Thanks for noticing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions