Repository navigation
2.0.0 dev.2 - #3
Merged
Merged
Conversation
Bumps [credo](https://github.com/rrrene/credo) from 1.3.2 to 1.4.0. - [Release notes](https://github.com/rrrene/credo/releases) - [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md) - [Commits](rrrene/credo@v1.3.2...v1.4.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.21.3 to 0.22.0. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/master/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.21.3...v0.22.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.22.0 to 0.22.1. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/master/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.22.0...v0.22.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [excoveralls](https://github.com/parroty/excoveralls) from 0.12.3 to 0.13.0. - [Release notes](https://github.com/parroty/excoveralls/releases) - [Changelog](https://github.com/parroty/excoveralls/blob/master/CHANGELOG.md) - [Commits](parroty/excoveralls@v0.12.3...v0.13.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [excoveralls](https://github.com/parroty/excoveralls) from 0.13.0 to 0.13.1. - [Release notes](https://github.com/parroty/excoveralls/releases) - [Changelog](https://github.com/parroty/excoveralls/blob/master/CHANGELOG.md) - [Commits](parroty/excoveralls@v0.13.0...v0.13.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.22.1 to 0.22.2. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/master/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.22.1...v0.22.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.22.2 to 0.22.5. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/master/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.22.2...v0.22.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.22.5 to 0.22.6. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/master/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.22.5...v0.22.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [excoveralls](https://github.com/parroty/excoveralls) from 0.13.1 to 0.13.2. - [Release notes](https://github.com/parroty/excoveralls/releases) - [Changelog](https://github.com/parroty/excoveralls/blob/master/CHANGELOG.md) - [Commits](parroty/excoveralls@v0.13.1...v0.13.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [credo](https://github.com/rrrene/credo) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/rrrene/credo/releases) - [Changelog](https://github.com/rrrene/credo/blob/v1.4.1/CHANGELOG.md) - [Commits](rrrene/credo@v1.4.0...v1.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.22.6 to 0.23.0. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/master/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.22.6...v0.23.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Minor refactor to make the generated code a little more readable.
Minor refactor for readability of compiled code.
Bumps [excoveralls](https://github.com/parroty/excoveralls) from 0.13.2 to 0.13.3. - [Release notes](https://github.com/parroty/excoveralls/releases) - [Changelog](https://github.com/parroty/excoveralls/blob/master/CHANGELOG.md) - [Commits](parroty/excoveralls@v0.13.2...v0.13.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Elixir is slow to compile functions with many heads, which is how we generate enums in this library. It's faster to compile an equivalent case statement inside a single function head. I observed that it reduced the time to compile an enum with about 2500 values from 24s to 3s.
Bumps [credo](https://github.com/rrrene/credo) from 1.4.1 to 1.5.0. - [Release notes](https://github.com/rrrene/credo/releases) - [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md) - [Commits](rrrene/credo@v1.4.1...v1.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
We could use server-side metrics for Thrift services. Standard metrics for every endpoint like QPS, latency, request/response size, and success rate. In order to avoid coupling to our internal metrics library, I left the interface pluggable. This also facilitates testing by substituting a stub implementation in tests.
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.26.0 to 0.27.3. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.26.0...v0.27.3) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [credo](https://github.com/rrrene/credo) from 1.6.1 to 1.6.2. - [Release notes](https://github.com/rrrene/credo/releases) - [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md) - [Commits](rrrene/credo@v1.6.1...v1.6.2) --- updated-dependencies: - dependency-name: credo dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.27.3 to 0.28.0. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.27.3...v0.28.0) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [credo](https://github.com/rrrene/credo) from 1.6.2 to 1.6.3. - [Release notes](https://github.com/rrrene/credo/releases) - [Changelog](https://github.com/rrrene/credo/blob/master/CHANGELOG.md) - [Commits](rrrene/credo@v1.6.2...v1.6.3) --- updated-dependencies: - dependency-name: credo dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.28.0 to 0.28.1. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.28.0...v0.28.1) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.28.2 to 0.28.3. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.28.2...v0.28.3) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [telemetry](https://github.com/beam-telemetry/telemetry) from 1.0.0 to 1.1.0. - [Release notes](https://github.com/beam-telemetry/telemetry/releases) - [Changelog](https://github.com/beam-telemetry/telemetry/blob/main/CHANGELOG.md) - [Commits](beam-telemetry/telemetry@v1.0.0...v1.1.0) --- updated-dependencies: - dependency-name: telemetry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.28.3 to 0.28.4. - [Release notes](https://github.com/elixir-lang/ex_doc/releases) - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.28.3...v0.28.4) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [excoveralls](https://github.com/parroty/excoveralls) from 0.14.4 to 0.14.5. - [Release notes](https://github.com/parroty/excoveralls/releases) - [Changelog](https://github.com/parroty/excoveralls/blob/master/CHANGELOG.md) - [Commits](parroty/excoveralls@v0.14.4...v0.14.5) --- updated-dependencies: - dependency-name: excoveralls dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Tests on other PRs are failing with the following error:
Error: Requested Erlang/OTP version (23) not found in version list (should you be using option 'version-type': 'strict'?)
I tried changing the Ubuntu version used in the CI environment based on
Googling for ideas, and it seems to get the tests running.
Starting with Ranch 2.0, you get a warning when mixing Ranch and TCP socket options in a single keyword list. We only support the old syntax, so you'll get warnings at startup, and presumably that syntax will stop working at some point. This diff adds support for the new syntax. It does so in a backwards compatible way, so you can upgrade Ranch and your option syntax either before or after upgrading elixir-thrift.
Coverage Report for CI Build 0Coverage decreased (-1.9%) to 90.671%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No actual review needed, I'm just making sure all the CI still works.