Repository navigation
Require elixir >= 1.18 and OTP >= 27. Unpin all deps. - #4
Open
nathanmonteleone wants to merge 9 commits into
Open
nathanmonteleone wants to merge 9 commits into
nathanmonteleone wants to merge 9 commits into
Conversation
…ests that won't run. Just use a catchall instead
- Fix map default values generating invalid AST in struct_generator: Utils.quote_value
for maps was returning an actual %{} Elixir map rather than proper AST ({:%{}, [], pairs}).
Elixir 1.18 introduced stricter unquote validation that rejects non-AST values.
- Fix struct update warnings in Elixir 1.19 by adding explicit %StructName{} = var
pattern matches to function heads in ast.ex (all merge/2 clauses), generator.ex
(generate_schema/1, generate_to_string!/1 lambda), and file_group.ex
(set_current_module/2).
- Remove --force from mix compile --warnings-as-errors in CI: --force was causing
the connection dependency to be recompiled under warnings-as-errors, surfacing
its charlist deprecation warnings as errors. deps.compile handles dep compilation
separately; without --force, mix compile only recompiles changed project files.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 3Coverage decreased (-1.4%) to 89.237%Details
Uncovered Changes
Coverage Regressions28 previously-covered lines in 8 files lost coverage.
Coverage Stats
💛 - Coveralls |
- Update ExUnit.Case.register_test/4 → register_test/6 in thrift_test macro (deprecated in Elixir 1.18, fails under --warnings-as-errors) - Regenerate test SSL certs with a proper CA chain (ca_cert.pem + ca_key.pem) - Update build_ssl_client/1 to pass cacertfile + verify: :verify_peer (OTP 25+ SSL clients default to verify_peer, requiring explicit cacertfile) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lity The 6-arity form of register_test/6 (deprecated since 1.14) passes Macro.Env to Module.has_attribute?/2 internally, which no longer accepts a Macro.Env struct in Elixir 1.19 — only module atoms. Switch to the 4-arity form register_test/4 which was designed to accept Macro.Env directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
OTP 25+ uses the connected IP address (127.0.0.1) for certificate hostname verification when verify_peer is enabled. The old cert only had CN=localhost with no Subject Alternative Names, causing a hostname_check_failed error since IP-based verification requires an IP SAN, not just a CN match. Regenerated server cert with: - DNS SAN: localhost - IP SAN: 127.0.0.1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kthomas-simplifi
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.