qml: close keyboard when tapping on ElDialog background - #10941
Open
f321x wants to merge 1 commit into
Open
Conversation
f321x
marked this pull request as draft
September 7, 2026 15:43
f321x
force-pushed
the
qml_close_keyboard
branch
3 times, most recently
from
September 8, 2026 08:31
17d140c to
8bc50c0
Compare
f321x
marked this pull request as ready for review
September 8, 2026 08:31
When showing the keyboard over an ElDialog (e.g. when entering a comment into the lnurlpay dialog) it can only be closed using the android back button or the little "hide keyboard" button in the os system bar. Instead it is nicer if it is also possible to close the keyboard by clicking on some empty area of the dialog. Keep focus on contentItem so the wizards back button hook keeps working.
f321x
force-pushed
the
qml_close_keyboard
branch
from
September 8, 2026 09:38
8bc50c0 to
c1743d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When showing the keyboard over an ElDialog (e.g. when entering a comment into the lnurlpay dialog) it can only be closed using the android back button or the little "hide keyboard" button in the os system bar.
Instead it is nicer if it is also possible to close the keyboard by clicking on some empty area of the dialog.
Tested on Pixel 9.