Repository navigation
Clarify job status handling in afterJob - #5612
Open
nippyclouding wants to merge 1 commit into
Open
nippyclouding wants to merge 1 commit into
nippyclouding wants to merge 1 commit into
Conversation
See spring-projects#5243 Signed-off-by: Lee Sang Won <nippyclouding@gmail.com>
Contributor
|
While I love seeing active contributions, mass-submitting PRs in a short period can put a heavy burden on the maintainers. It would be great if you could group minor changes into a single PR whenever possible. |
Author
Thanks for the feedback |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job status is saved before
afterJobruns. Clarify that this callback observes an already-persisted status and should not change it. Link toJobExecution.getStatus()to make clear which status is being discussed.Related to #5243, specifically the Javadoc clarification mentioned in this comment.
Validation:
./mvnw -B -ntp package