Migrate @Import classes to use constructor injection - #51490
Open
piyushrajyadav wants to merge 1 commit into
Open
Migrate @Import classes to use constructor injection#51490piyushrajyadav wants to merge 1 commit into
piyushrajyadav wants to merge 1 commit into
Conversation
Use constructor injection for BeanFactory in ImportBeanDefinitionRegistrar implementations instead of implementing BeanFactoryAware. Closes spring-projectsgh-18231 Signed-off-by: piyushrajyadav <piyushyadavrajyadav@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates several
@ImportandImportBeanDefinitionRegistrarclasses from implementingBeanFactoryAwareto using constructor injection forBeanFactory, following the guidance on #18231 and Spring Framework's support for constructor injection in@Importclasses.Changes Made
PrimaryDefaultValidatorPostProcessor: Replacedimplements BeanFactoryAwareandsetBeanFactory(BeanFactory)withPrimaryDefaultValidatorPostProcessor(BeanFactory beanFactory)constructor injection.ServletWebServerConfiguration.BeanPostProcessorsRegistrar: Replacedimplements BeanFactoryAwareandsetBeanFactory(BeanFactory)withBeanPostProcessorsRegistrar(BeanFactory beanFactory)constructor injection.ReactiveWebServerConfiguration.BeanPostProcessorsRegistrar: Replacedimplements BeanFactoryAwareandsetBeanFactory(BeanFactory)withBeanPostProcessorsRegistrar(BeanFactory beanFactory)constructor injection.IntegrationAutoConfigurationScanRegistrar: Replacedimplements BeanFactoryAwareandsetBeanFactory(BeanFactory)withIntegrationAutoConfigurationScanRegistrar(BeanFactory beanFactory)constructor injection.Verification
All modified modules were formatted using
./gradlew formatand verified against Checkstyle and full unit/integration test suites::module:spring-boot-validation:test(PASSED):module:spring-boot-validation:checkstyleMain(PASSED):module:spring-boot-validation:checkstyleTest(PASSED):module:spring-boot-web-server:test(PASSED):module:spring-boot-web-server:checkstyleMain(PASSED):module:spring-boot-web-server:checkstyleTest(PASSED):module:spring-boot-integration:test(PASSED):module:spring-boot-integration:checkstyleMain(PASSED):module:spring-boot-integration:checkstyleTest(PASSED)Closes #18231