jarmode tools commands print stacktrace instead of an error message - #51540
Merged
mhalbritter merged 1 commit intoSep 2, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
xxxxxxjun
force-pushed
the
fix-tools-jarmode-error-message
branch
from
September 2, 2026 09:44
db0210f to
be7ca77
Compare
mhalbritter
changed the title
mhalbritter
added
type: bug
See spring-projectsgh-51540 Signed-off-by: Hyeongjun Cho <ryuu.public@gmail.com>
mhalbritter
force-pushed
the
fix-tools-jarmode-error-message
branch
from
September 2, 2026 14:22
be7ca77 to
d92a75c
Compare
This was referenced Sep 2, 2026
Contributor
|
Thanks @xxxxxxjun ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #51505 at @mhalbritter's request.
The tools jar mode wraps every exception in
IllegalStateException, so aJarModeErrorExceptionthrown by a command never reaches the branch ofJarModeRunnerthat printsError: <message>. Runninglist-layersagainst a jar built without layers shows a stack trace instead ofError: Layers are not enabled.JarModedeclaresrunasthrows JarModeErrorException"on an error that should print a simple error message", so the wrapping breaks that contract. It predates the exception: #43435 added JarModeErrorExceptionand convertedExtractCommandandLayers, but leftToolsJarMode` alone. Rethrowing ahead of the generic catch restores the branch.