Repository navigation
Preserve OpenAPI 3.1 type arrays in MCP input schemas - #3428
Open
mariodavid wants to merge 1 commit into
Open
mariodavid wants to merge 1 commit into
mariodavid wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The MCP schema converter reads a single entry from OpenAPI 3.1's
Schema#getTypes(). A request property declared as["string", "null"]loses one of its allowed types in the generated MCPinputSchema.Fix
Emit a JSON Schema
typearray when the OpenAPI schema has multiple types. The existing single-type and OpenAPI 3.0nullable: truepaths still apply.Tests
OpenApiSchemaConverterTest#testOpenApi31TypeArraysInRequestBodyparses a request body and verifies both["string", "null"]and["integer", "string"]. It fails on the old converter../mvnw -pl springdoc-openapi-starter-common-mcp -am testpasses, including all 35 MCP module tests.content: null, and reads the saved note back.Fixes #3427.