Convert assert() to static_assert() where feasible (#2492) - #2504
Merged
Merged
Conversation
This change covers all known cases where such conversion is a good idea and does not require other code changes. Clang-tidy `misc-static-assert` tool that detects `assert()` conditions that can be computed at compile time does not detect any additional candidates except `assert(false)` and similar unreachable code markers.
yadij
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change covers all known cases where such conversion is a good idea
and does not require other code changes. Clang-tidy
misc-static-asserttool that detects
assert()conditions that can be computed at compiletime does not detect any additional candidates except
assert(false)and similar unreachable code markers.