Skip to content

Add stackhpc/hardware to repo management - #590

Merged
priteau merged 5 commits into
mainfrom
add-hardware
Nov 12, 2026
Merged

priteau merged 5 commits into
mainfrom
add-hardware

Conversation

@MoteHue

@MoteHue MoteHue commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Added to the Kayobe team, as this is used in seed deployment image builds.

https://github.com/stackhpc/hardware/

Added to the Kayobe team, as this is used in seed deployment image
builds.

https://github.com/stackhpc/hardware/
@MoteHue
MoteHue requested a review from a team as a code owner November 9, 2026 16:39
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Summary

Added stackhpc/hardware to the source repository configuration and the Kayobe team’s repository list.

The change registers the hardware repository in the Ansible source repository configuration and adds it to the Kayobe repository list in Terraform variables.

Changes: Hardware repository registration

Layer / File(s) Summary
Configure repository registration
ansible/inventory/group_vars/all/source-repositories, terraform/github/terraform.tfvars.json
The Ansible configuration adds hardware as a single-branch repository, with the tox workflow on its default branch and Kayobe team CODEOWNERS content. The Kayobe repository list also adds hardware.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Merge Risk: Moderate · previous review 5861a

The hardware repository registration is likely to fail the source repository sync, which can stop later repositories from being processed. Change the workflows value to a plain list containing tox. Before merging, confirm the hardware repository is imported into Terraform state, because otherwise the apply may try to create a repository that already exists.

Pre-merge checks: Passed 3

Check name Status Explanation
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3cdba66 and 3486b4e.

Files selected for processing: 2

  • ansible/inventory/group_vars/all/source-repositories
  • terraform/github/terraform.tfvars.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread terraform/github/terraform.tfvars.json Resolved
@stackhpc-ci

stackhpc-ci commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @dougszumski, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3486b4e and 5861ab9.

Files selected for processing: 1

  • ansible/inventory/group_vars/all/source-repositories

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
jovial
jovial previously approved these changes Nov 10, 2026
Add destination for CODEOWNERS file in community files.

@dougszumski dougszumski left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a follow up to protect the master branch on stackhpc/hardware would be helpful. Approving since I can't apply the change for the monitoring team as it's complaining that hardware is not in tfvars.

Not that my approval means anything :D

@priteau
priteau disabled auto-merge November 12, 2026 16:10
@priteau
priteau merged commit 7f19f1a into main Nov 12, 2026
6 checks passed
@priteau
priteau deleted the add-hardware branch November 12, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants