Skip to content

Fix dcqal-mso-mdoc-aamva-namespace - #29

Closed
grahamallen-1 wants to merge 3 commits into
stateofca:mainfrom
spruceid:main
Closed

grahamallen-1 wants to merge 3 commits into
stateofca:mainfrom
spruceid:main

Conversation

@grahamallen-1

Copy link
Copy Markdown
Contributor

Fix DCQL mso_mdoc credential query generation when a query spans both the base ISO namespace (org.iso.18013.5.1) and its AAMVA sub-namespace (org.iso.18013.5.1.aamva). Today this produces an invalid query that wallets reject.

@djscruggs

Copy link
Copy Markdown
Collaborator

Thanks for the fix. Digital Bazaar's active development happens in the canonical opencred-platform repo, and this change is already tracked there with the same code plus a CHANGELOG entry. Closing here to avoid a duplicate landing and re-syncing. The public stateofca/opencred repo is a downstream mirror that we sync from platform periodically, so this fix will arrive here through that sync.

@Ryanmtate

Copy link
Copy Markdown
Contributor

Thanks for the fix. Digital Bazaar's active development happens in the canonical opencred-platform repo, and this change is already tracked there with the same code plus a CHANGELOG entry. Closing here to avoid a duplicate landing and re-syncing. The public stateofca/opencred repo is a downstream mirror that we sync from platform periodically, so this fix will arrive here through that sync.

@djscruggs Do you know of a timeline for OpenCred to support mso_mdoc + W3C VC credentials in a single DCQL? Our understanding is that this is currently not supported.

jonnyg23 pushed a commit that referenced this pull request Sep 16, 2026
Build a single mso_mdoc credential whose claims span every requested
namespace instead of one credential per namespace. A query that spanned
both the base ISO namespace (org.iso.18013.5.1) and its AAMVA
sub-namespace (org.iso.18013.5.1.aamva) previously emitted two
credentials sharing a duplicate id: '0' and a bogus doctype_value
(org.iso.18013.5.1.aamva.mDL) that wallets reject.

All mso_mdoc namespaces belong to the same mDL doctype, so
buildMsoMdocCredentials now flattens claims across namespaces and derives
doctype_value from the base (shortest) namespace, independent of
namespace order. The downstream intent_to_retain stamping is unchanged.

Ported from #29 by grahamallen-1 and adapted to the
current _buildDcqlQueryForMdoc pipeline.
@djscruggs djscruggs closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants