CI: build sandbox static output inside the create job#35352
Draft
valentinpalkovic wants to merge 1 commit into
Draft
CI: build sandbox static output inside the create job#35352valentinpalkovic wants to merge 1 commit into
valentinpalkovic wants to merge 1 commit into
Conversation
The standalone (build) job per template was ~90s of which ~55s was fixed
setup (spin-up, checkout, workspace attach and unpack) around a ~25-45s
build - and it sat between (create) and the e2e/chromatic/vitest jobs on
the workflow critical path, adding a full job hop plus a workspace
round-trip to those chains.
The static build now runs at the end of the create job, before the sandbox
is packed, so storybook-static travels inside the existing sandbox tarball
and downstream jobs need no extra restore step. e2e, chromatic, vitest and
test-runner depend on create directly.
The Windows sandbox jobs and the daily test-runner job referenced flow
jobs by array index; they now use named references, since the build job no
longer exists. saveBench('build') records identical data - it runs inside
'yarn task build' regardless of which CI job hosts it, and no job in the
generated workflows consumed the bench task output.
valentinpalkovic
added
build
Contributor
|
|
View your CI Pipeline Execution ↗ for commit b942760
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35343; stacked on #35350. Removes one full job level from every sandbox template's static chain.
Why
After the Playwright-workers win (#35347), the workflow tail shifts to the four-level chain build-linux → create → build → {e2e, chromatic, vitest}. The standalone
(build)job is ~90s, of which ~55s is fixed setup (spin-up, checkout, attach, unpack) around a ~25-45s actual build - and every downstream job waits for it plus another workspace round-trip.What
yarn task buildruns at the end of the(create)job, before the sandbox is packed, sostorybook-statictravels inside the existing per-template sandbox tarball (CI: pack sandboxes into gzipped workspace tarballs #35348).(e2e),(chromatic),(vitest)and(test-runner)depend on(create)directly - they start ~1.5 min earlier.Coverage unchanged: the same
yarn task buildruns with the same inputs and assertions, one job earlier.saveBench('build')records identical data (it runs inside the task, not the job), and no generated workflow consumed the bench task output.Expected effect (to be replaced with measured numbers from this PR's pipeline)
Measured tables will be updated from the CI run on this PR.