Angular: Rewrite @storybook/angular imports outside stories in angular-to-angular-vite migration

[valentinpalkovic]

Follow-up bug fix for the @storybook/angular-vite work (#34202). Found during QA on the Bitwarden clients repo.

What I did

:ladybug: The issue

After automigrating an Angular 21 project from @storybook/angular to @storybook/angular-vite, some files still import from @storybook/angular - which no longer exists once the migration removes it from package.json. The build/typecheck then breaks for any story that pulls one of those files in.

Root cause

The import-rewrite step only fed two things into transformImportFiles:

const configFiles = configDir ? await globby([`${configDir}/**/*`]) : [];
const allFiles = [...storiesPaths, ...configFiles].filter(Boolean);

storiesPaths is strictly *.stories.* files (it comes from the stories glob), and configFiles is only the .storybook config dir. Angular projects import from @storybook/angular in a lot of non-story modules though - shared decorators, moduleMetadata/applicationConfig helpers, *.mock.ts, test setup, per-component helpers. None of those are in either set, so they were silently skipped.

The fix

Also scan the project directory (the folder that holds the Storybook config) for source files and run them through the same rewrite, deduped with the existing sets:

const projectSourceFiles = await globby(['**/*.{ts,tsx,mts,cts,js,jsx,mjs,cjs}'], {
  cwd: dirname(configDir),
  absolute: true,
  gitignore: true,
  ignore: ['**/node_modules/**', '**/dist/**', '**/.storybook-static/**', '**/.angular/**', '**/coverage/**'],
});
const allFiles = [...new Set([...storiesPaths, ...configFiles, ...projectSourceFiles].filter(Boolean))];

Two deliberate choices:

• Scoped to the project, not the repo root. In a partially-migrated monorepo we must not rewrite @storybook/angular imports in sibling projects that stayed on the Webpack framework, so I glob dirname(configDir) rather than getProjectRoot().
• Over-including is safe. transformImportFiles only rewrites quoted @storybook/angular specifiers and correctly leaves @storybook/angular-vite alone, so the worst case for an unrelated file is a wasted read.

Heads-up: the same storiesPaths + configDir scanning shape exists in nextjs-to-nextjs-vite.ts, consolidated-imports.ts, and renderer-to-framework.ts. I kept this PR scoped to the Angular fix, but we may want to align the others in a follow-up. WDYT?

How to test

• New unit tests in angular-to-angular-vite.test.ts:
  • a non-story helper importing @storybook/angular is now included in the rewrite scan
  • a file present in both storiesPaths and the project scan is deduped to a single entry
• yarn vitest run code/lib/cli-storybook/src/automigrate/fixes/angular-to-angular-vite.test.ts

Draft while I land the sibling QA fixes.

[github-actions]

	Fails
🚫	PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]
🚫	PR is not labeled with one of: ["ci:normal","ci:merged","ci:daily","ci:docs"]
🚫	PR is not labeled with one of: ["qa:needed","qa:skip","qa:success"]
🚫	PR description is missing the mandatory "#### Manual testing" section. Please add it so that reviewers know how to manually test your changes.

Generated by 🚫 dangerJS against a2f53a5