Repository navigation
Conversation
Author
|
@JosephSBoyle Thanks again, the PR is up. I’d appreciate your thoughts on the proposed min_gap logic. |
JosephSBoyle
reviewed
Oct 7, 2026
JosephSBoyle
left a comment
There was a problem hiding this comment.
@thebean27 Thank you for this PR I had some suggestions for the prose but other than that it looks good.
One other thing I might suggest would be standardising the docs and examples to use a fixed period, either 3hrs or 1 day seem like reasonable candidates to my mind. If people default to the same thing this could help reproducibility. :)
Cheers,
Joe
Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>
Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com>
|
Looks fine to me, thanks @thebean27 @jhnwu3, I wonder if there should be a MIMIC-3 equivalent of this PR. Best |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an optional
min_gapparameter toReadmissionPredictionMIMIC4.Very short intervals between discharge and the next admission may represent internal transfers rather than true readmissions. With
min_gap, users can define a minimum interval that must pass before a subsequent admission is labeled as a readmission.min_gap=Nonepreserves the existing behavior.Testing
python -m unittest discover -s tests/core -p 'test_mimic4_readmission_prediction.py' -vAll 10 tests pass.
Also checked:
with no errors.
Fixes #1269