Repository navigation
fix(pr-merge-tracker): review complete diffs and compute honest review depth - #4
Open
sunwrobert wants to merge 1 commit into
Open
sunwrobert wants to merge 1 commit into
sunwrobert wants to merge 1 commit into
Conversation
…w depth Adds scripts/collect_diffs.py, which diffs merge base and head in a blob-filtered bare cache so reviews are not capped at 300 files or 20,000 lines, chunks the full patch, separates required from mechanical and generated files, and computes reviewDepth from the chunks a reviewer actually read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The skill used to review
gh pr diffoutput. Large PRs got cut to a sample, and the saved review depth still said full. In one run, 182 of 266 reviews came from incomplete patches, but the state labeled themfull-net-diff.skills/pr-merge-tracker/scripts/collect_diffs.py. It diffs the merge base against the head in a blob-filtered bare git cache, so there are no API file or line caps. It writes the full patch, a file inventory, and 80,000-character chunks, with hunks split and never cut off.depthcomputesfullorsampled N%from the chunk IDs a reviewer actually read. SKILL.md now forbids writing the depth by hand and requiressampled N%in report bullets.Testing
Ran against
OpenRouterTeam/openrouter-web:full.sampled 36%.sampled 1%.bun run checkreports a format issue inexecutor/executor.jsonc, which was already onmain; the changed files passoxfmt --check.