Repository navigation
Conversation
The ruleset lets the repository admin bypass the review and the required checks from a pull request, so the gate binds contributors and not the maintainer. The documentation said administrators may not bypass. State the setting that is actually in force. Change-Id: I5b39fc82e900440ad64c3e5e6827acd2f0a3851d
The ruleset does not require approval of the most recent push, and a sole maintainer who authors a pull request could not satisfy it. State the rules that are in force. Change-Id: I37be8f724e77e65b164c1769acfa015ff710d1d8
Contributor
Author
|
Superseded by #574, which carries this fix as its first commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main review gate ruleset lets the repository admin bypass the review and the required checks from a pull request, but docs/development.md said administrators may not bypass, and that the most recent push needs approval, which the ruleset does not require. This states the settings that are actually in force, and says that the gate binds contributors and not the maintainer. Documentation only.
Interactive review: not required
Head: 2676d10
Base: d6b90af
Diff: sha256:99c89af49556198cda056a5eb2bf8750892e879e20fa6367c1170bff40db33f6
PR text lines: 10; commits at 200 lines or more: 0