Repository navigation
feat(performance): perf-metrics, diagnostics and diagnostic-logs over REST - #36
Merged
Merged
Conversation
…s over REST PerformanceMetric, DiagnosticSignatureInfo and DiagnosticLogEntry now declare structuredAffordances (CLI output unchanged) and Presentable; the list commands take affordanceMode. New routes for build metrics, build diagnostics and signature logs, served by PerfMetricsController and DiagnosticsController. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CI and release builds use Swift 6.2.4, which can't infer `.init(rawValue:)`
inside `value.flatMap { .init(…) }.map { [$0] }` (Swift 6.4 can), so main
has failed to build on CI since #32. Route the eight filter parameters
through a generic `sdkFilter(_:)` whose SDK type comes from the parameter.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 82.04% 82.68% +0.63%
==========================================
Files 492 519 +27
Lines 14362 15637 +1275
==========================================
+ Hits 11784 12929 +1145
- Misses 2578 2708 +130
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
asc perf-metrics,asc diagnosticsandasc diagnostic-logswere CLI-only. Their routes were registered but nothing served them, so_linksresolved to nothing.What changed
perf-metrics list --app-idGET /api/v1/apps/:appId/perf-metrics?metric-type=perf-metrics list --build-idGET /api/v1/builds/:buildId/perf-metrics?metric-type=diagnostics list --build-idGET /api/v1/builds/:buildId/diagnostics?diagnostic-type=diagnostic-logs list --signature-idGET /api/v1/diagnostics/:signatureId/logsstructuredAffordancesandPresentable. CLI output is byte-identical; the existing command tests pass unedited.How it was verified
affordanceMode, then 8 link tests with empty_links.swift testpasses.Checklist
swift testpassesasc web-server## [Unreleased]inCHANGELOG.mdmake docs && make check-docspasses.p8, issuer ID or Apple ID session in the diff, output or screenshots🤖 Generated with Claude Code