Repository navigation
test: Harden behavior coverage and fix discovered regressions - #461
Merged
Merged
Conversation
Generated by 🚫 Danger Swift against 68903f0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strengthen behavior coverage beyond page counts while preserving Arrange–Act–Assert. Add boundary, isolation, content-order, Unicode/attribute, external-page selection, merge, and error-propagation checks, with typed scenarios and reviewable expectation records.
Keep regression tests for two reproduced bugs: table copies dropped the cell-splitting setting, and multi-document file output ignored explicit metadata. Both fixes are one-line changes and have generated-PDF coverage.
Verification
Focused macOS checks and the full macOS suite passed: 240 unit-test declarations and 12 integration-test declarations, including parameterized cases. Lint and diff checks passed, and the testing flag is restored. Other platforms were not tested. Existing PDF-context nesting and compiler/Xcode diagnostics remain.
Migration audit
Reviewed the nine Swift Testing migrations in #452–#460. No lost active scenario was found in the comparisons reviewed. Removed placeholders were empty or commented out. This is a prioritized hardening pass, not exhaustive edge-case coverage.