remove reset_heartbeats field in ResetActivityExecutionRequest#820
Open
spkane31 wants to merge 1 commit into
Open
remove reset_heartbeats field in ResetActivityExecutionRequest#820spkane31 wants to merge 1 commit into
spkane31 wants to merge 1 commit into
Conversation
5 tasks
fretz12
reviewed
Jul 9, 2026
|
|
||
| // If activity is paused, it will remain paused after reset | ||
| bool keep_paused = 7; | ||
| bool keep_paused = 6; |
Contributor
There was a problem hiding this comment.
I'm assuming swapping is ok if no one uses this API?
Safe thing to do is:
reserved 6;
reserved "reset_heartbeat";
// If activity is paused, it will remain paused after reset
bool keep_paused = 7;
...
| - WIRE_JSON | ||
| ignore: | ||
| ignore_only: |
Contributor
There was a problem hiding this comment.
if we did my above comment, I don't think we need this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Remove the
reset_heartbeatfield fromtemporal.api.workflowservice.v1.ResetActivityExecutionRequest.Why?
The new default behavior will be to reset heartbeats with a reset request so this field is no longer needed.
Breaking changes
This is technically a breaking change, but this endpoint has not been published in the server yet so no users can actually use this field.
Server PR
N/A