Adding SDK Ergonomics Query link - #2988
Open
Evanthx wants to merge 2 commits into
Open
Conversation
Contributor
What duplication? I am not aware of any except for what we had in the Go SDK/Server |
| .setNexusServiceImplementation(new QueryingNexusServiceImpl()) | ||
| // The workflow being queried parks on a signal, so time skipping would fast-forward it | ||
| // into its execution timeout and it would be gone before the Query lands. | ||
| .setUseTimeskipping(false) |
Contributor
There was a problem hiding this comment.
You'll need an assume in this class too, to stop these test from running against the test server in CI
| * a query handler that throws, and a Query rejected by the client's reject condition. All of these | ||
| * must fail the caller's Nexus operation rather than hanging or returning a default. | ||
| * | ||
| * <p>The response link the server attaches to {@code QueryWorkflowResponse} is verified in {@link |
Contributor
There was a problem hiding this comment.
This test should assert on the link , we will need to publish a real server before we merge this anyway
Contributor
|
Other then the tests the actual SDK changes LGTM |
Contributor
|
FWIW I also ran a Codex review and it only had one finding |
Quinn-With-Two-Ns
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one thing to note is that there was some duplication around link converters and still is. I would like to fix that separately, and have created an epic to check over the link converters for each SDK which I am planning on doing in the next sprint.
https://temporalio.atlassian.net/browse/NEXUS-578
The proto bump brings in the link field.